Fix PreviousFork never selecting a fork at epoch 0 - #90
Open
damilolaedwards wants to merge 1 commit into
Open
Conversation
The search seeded its running maximum at epoch 0 and only replaced it on a strict greater than, so a fork activating at epoch 0 could never win. Every real chain has its genesis fork at epoch 0, so PreviousFork returned "no previous fork" on any mainnet-shaped spec. Changed the comparison to greater than or equal, matching how CurrentFork already does this same search.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The search seeded its running maximum at epoch 0 and only replaced it on a strict greater than, so a fork activating at epoch 0 could never win. Every real chain has its genesis fork at epoch 0, so PreviousFork returned "no previous fork" on any mainnet-shaped spec.
Fix changes the comparison to greater than or equal, matching how CurrentFork already does this same search.
Test plan